Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-569-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-569-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #569: [ARTEMIS-558] java.util.MissingFormatArg...
Content-Type: text/plain
Message-Id: <20160607165337.3BC1ADFDA9@git1-us-west.apache.org>
Date: Tue,  7 Jun 2016 16:53:37 +0000 (UTC)
archived-at: Tue, 07 Jun 2016 16:53:39 -0000

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/569#discussion_r66109312
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java ---
    @@ -576,23 +576,30 @@ public void lateDeliveryRollback(PagePosition position) {
     
        @Override
        public boolean isComplete(long page) {
    -      logger.tracef("%s isComplete %d", this, page);
    +      if (empty && consumedPages.isEmpty()) {
    +         logger.tracef("%s isComplete %d", this, page);
    +      }
    +
           synchronized (consumedPages) {
              if (empty && consumedPages.isEmpty()) {
                 if (logger.isTraceEnabled()) {
    -               logger.tracef("isComplete(%d)::Subscription %s has empty=%s, consumedPages.isEmpty=%s", (Object)page, this, consumedPages.isEmpty());
    +               logger.tracef("isComplete(%d)::Subscription %s has empty=%s, consumedPages.isEmpty=%s", page, this, empty, consumedPages.isEmpty());
                 }
                 return true;
              }
     
              PageCursorInfo info = consumedPages.get(page);
     
              if (info == null && empty) {
    -            logger.tracef("isComplete(%d)::::Couldn't find info and it is empty", page);
    +            if (empty && consumedPages.isEmpty()) {
    +               logger.tracef("isComplete(%d)::::Couldn't find info and it is empty", page);
    +            }
                 return true;
              }
              else {
    -            logger.tracef("isComplete(%d)::calling is %s", (Object)page, this, consumedPages.isEmpty());
    +            if (empty && consumedPages.isEmpty()) {
    --- End diff --
    
    The intention of this log was to log the else... and look (trace) the result of isEmpty, etc
    I would just remove the if


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---