activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtaylor <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #590: Mapped journal
Date Wed, 22 Jun 2016 09:55:58 GMT
Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/590#discussion_r68025330
  
    --- Diff: artemis-journal/pom.xml ---
    @@ -15,57 +15,81 @@
       limitations under the License.
     -->
     <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    -   <modelVersion>4.0.0</modelVersion>
    +    <modelVersion>4.0.0</modelVersion>
     
    -   <parent>
    -      <groupId>org.apache.activemq</groupId>
    -      <artifactId>artemis-pom</artifactId>
    -      <version>1.4.0-SNAPSHOT</version>
    -   </parent>
    +    <parent>
    +        <groupId>org.apache.activemq</groupId>
    +        <artifactId>artemis-pom</artifactId>
    +        <version>1.4.0-SNAPSHOT</version>
    +    </parent>
     
    -   <artifactId>artemis-journal</artifactId>
    -   <packaging>jar</packaging>
    -   <name>ActiveMQ Artemis Journal</name>
    +    <artifactId>artemis-journal</artifactId>
    +    <packaging>jar</packaging>
    +    <name>ActiveMQ Artemis Journal</name>
     
    -   <properties>
    -      <activemq.basedir>${project.basedir}/..</activemq.basedir>
    -   </properties>
    +    <properties>
    +        <activemq.basedir>${project.basedir}/..</activemq.basedir>
    +    </properties>
     
    -   <dependencies>
    -      <dependency>
    -         <groupId>org.jboss.logging</groupId>
    -         <artifactId>jboss-logging-processor</artifactId>
    -         <scope>provided</scope>
    -         <optional>true</optional>
    -      </dependency>
    +    <dependencies>
    +        <dependency>
    +            <groupId>org.jboss.logging</groupId>
    +            <artifactId>jboss-logging-processor</artifactId>
    +            <scope>provided</scope>
    +            <optional>true</optional>
    +        </dependency>
     
    -      <!--
    -          JBoss Logging
    -      -->
    -      <dependency>
    -         <groupId>org.jboss.logging</groupId>
    -         <artifactId>jboss-logging</artifactId>
    -      </dependency>
    -      <dependency>
    -         <groupId>org.jboss.logmanager</groupId>
    -         <artifactId>jboss-logmanager</artifactId>
    -         <scope>test</scope>
    -      </dependency>
    -      <dependency>
    -         <groupId>org.apache.activemq</groupId>
    -         <artifactId>artemis-commons</artifactId>
    -         <version>${project.version}</version>
    -      </dependency>
    -      <dependency>
    -         <groupId>org.apache.activemq</groupId>
    -         <artifactId>artemis-native</artifactId>
    -         <version>${project.version}</version>
    -      </dependency>
    -      <!-- needed to compile the tests -->
    -      <dependency>
    -         <groupId>junit</groupId>
    -         <artifactId>junit</artifactId>
    -         <scope>test</scope>
    -      </dependency>
    -   </dependencies>
    -</project>
    +        <!--
    +            JBoss Logging
    +        -->
    +        <dependency>
    +            <groupId>org.jboss.logging</groupId>
    +            <artifactId>jboss-logging</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.jboss.logmanager</groupId>
    +            <artifactId>jboss-logmanager</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.activemq</groupId>
    +            <artifactId>artemis-commons</artifactId>
    +            <version>${project.version}</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.activemq</groupId>
    +            <artifactId>artemis-native</artifactId>
    +            <version>${project.version}</version>
    +        </dependency>
    +        <!-- needed to compile the tests -->
    +        <dependency>
    +            <groupId>junit</groupId>
    +            <artifactId>junit</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>net.openhft</groupId>
    --- End diff --
    
    I see.  Yes go ahead and do this, it should be alright.  I can review it once you've updated
the pom.
    
    As I am thinking about this more, the underlying issue we originally faced was that we
ship the tests as part of the build.  I just checked and we are not shipping the journal tests
nor do we depend on them in the integration tests.  So I think we're OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message