activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #590: Mapped journal
Date Tue, 21 Jun 2016 12:55:13 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/590#discussion_r67861830
  
    --- Diff: artemis-journal/pom.xml ---
    @@ -15,57 +15,81 @@
       limitations under the License.
     -->
     <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    -   <modelVersion>4.0.0</modelVersion>
    +    <modelVersion>4.0.0</modelVersion>
     
    -   <parent>
    -      <groupId>org.apache.activemq</groupId>
    -      <artifactId>artemis-pom</artifactId>
    -      <version>1.4.0-SNAPSHOT</version>
    -   </parent>
    +    <parent>
    +        <groupId>org.apache.activemq</groupId>
    +        <artifactId>artemis-pom</artifactId>
    +        <version>1.4.0-SNAPSHOT</version>
    +    </parent>
     
    -   <artifactId>artemis-journal</artifactId>
    -   <packaging>jar</packaging>
    -   <name>ActiveMQ Artemis Journal</name>
    +    <artifactId>artemis-journal</artifactId>
    +    <packaging>jar</packaging>
    +    <name>ActiveMQ Artemis Journal</name>
     
    -   <properties>
    -      <activemq.basedir>${project.basedir}/..</activemq.basedir>
    -   </properties>
    +    <properties>
    +        <activemq.basedir>${project.basedir}/..</activemq.basedir>
    +    </properties>
     
    -   <dependencies>
    -      <dependency>
    -         <groupId>org.jboss.logging</groupId>
    -         <artifactId>jboss-logging-processor</artifactId>
    -         <scope>provided</scope>
    -         <optional>true</optional>
    -      </dependency>
    +    <dependencies>
    +        <dependency>
    +            <groupId>org.jboss.logging</groupId>
    +            <artifactId>jboss-logging-processor</artifactId>
    +            <scope>provided</scope>
    +            <optional>true</optional>
    +        </dependency>
     
    -      <!--
    -          JBoss Logging
    -      -->
    -      <dependency>
    -         <groupId>org.jboss.logging</groupId>
    -         <artifactId>jboss-logging</artifactId>
    -      </dependency>
    -      <dependency>
    -         <groupId>org.jboss.logmanager</groupId>
    -         <artifactId>jboss-logmanager</artifactId>
    -         <scope>test</scope>
    -      </dependency>
    -      <dependency>
    -         <groupId>org.apache.activemq</groupId>
    -         <artifactId>artemis-commons</artifactId>
    -         <version>${project.version}</version>
    -      </dependency>
    -      <dependency>
    -         <groupId>org.apache.activemq</groupId>
    -         <artifactId>artemis-native</artifactId>
    -         <version>${project.version}</version>
    -      </dependency>
    -      <!-- needed to compile the tests -->
    -      <dependency>
    -         <groupId>junit</groupId>
    -         <artifactId>junit</artifactId>
    -         <scope>test</scope>
    -      </dependency>
    -   </dependencies>
    -</project>
    +        <!--
    +            JBoss Logging
    +        -->
    +        <dependency>
    +            <groupId>org.jboss.logging</groupId>
    +            <artifactId>jboss-logging</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.jboss.logmanager</groupId>
    +            <artifactId>jboss-logmanager</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.activemq</groupId>
    +            <artifactId>artemis-commons</artifactId>
    +            <version>${project.version}</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.activemq</groupId>
    +            <artifactId>artemis-native</artifactId>
    +            <version>${project.version}</version>
    +        </dependency>
    +        <!-- needed to compile the tests -->
    +        <dependency>
    +            <groupId>junit</groupId>
    +            <artifactId>junit</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>net.openhft</groupId>
    --- End diff --
    
    Hi Martyn,
    
    apologies more than accepted, i don't want to be so precise, but i've to learn better
the project OSS mechanics and I need to ask a lot of things that seem (maybe are) obvious:
so i greatly appreciate your patience.
    ASAP i'll fix this dep/licence issue; maybe during this night or the next one.
    Ok for IRC, i'haven't use it yet, so good to start here :+1: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message