activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #550: Jdbc refactor post
Date Wed, 01 Jun 2016 21:26:07 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/550#discussion_r65445835
  
    --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFile.java
---
    @@ -75,33 +57,30 @@
     
        private JDBCSequentialFileFactory fileFactory;
     
    -   private int maxSize;
    +   private final Object writeLock;
     
    -   private SQLProvider sqlProvider;
    +   private final JDBCFileFactoryDriver dbDriver;
     
    -   private final Object writeLock;
    +   private static final Logger log = Logger.getLogger(JDBCSequentialFile.class.getName());
    --- End diff --
    
    It seems that this was changed later on another commit...
    
    It gets really confusing to merge committs like this though. I would prefer these squashed
but that's just my preference


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message