activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From exabrial <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: Fix Issue #245
Date Thu, 19 May 2016 11:55:12 GMT
Github user exabrial commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/496#issuecomment-220302866
  
    I'm not completely sure it's correct actually... a better way would be go
    make the connection class an interface, rather than a final class.
    
    Also at Devoxx UK in two weeks I'm leading a workshop with the goal is to
    get this working 100%. If any of you will be available, or present
    physically, that'd be awesome!
    On May 19, 2016 5:30 AM, "Martyn Taylor" <notifications@github.com> wrote:
    
    > @exabrial <https://github.com/exabrial> Hi, any chance you could update
    > the commit message and we'll get this merged.
    >
    > Thanks
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/activemq-artemis/pull/496#issuecomment-220273790>
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message