activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: Auto-delete JMS, not just core
Date Thu, 05 May 2016 16:15:56 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/509#discussion_r62211110
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AutoCreatedQueueManagerImpl.java
---
    @@ -46,7 +46,7 @@ public void run() {
                       logger.debug("deleting auto-created queue \"" + queueName + ".\" consumerCount
= " + consumerCount + "; messageCount = " + messageCount + "; isAutoDeleteJmsQueues = " +
isAutoDeleteJmsQueues);
                    }
     
    -               server.destroyQueue(queueName, null, false);
    --- End diff --
    
    We you could have destroyQueue method the same here?
    shouldn't destroyQueue be calling getJMSQueueDeleter().delete(queueName); 
    
    ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message