activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-214 exception when sending ...
Date Mon, 25 Apr 2016 13:38:26 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/482#discussion_r60913426
  
    --- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/DeliveryUtil.java
---
    @@ -30,6 +30,9 @@ public static int readDelivery(Receiver receiver, ByteBuf buffer) {
           while ((count = receiver.recv(buffer.array(), buffer.arrayOffset() + buffer.writerIndex(),
buffer.writableBytes())) > 0) {
              // Increment the writer index by the number of bytes written into it while calling
recv.
              buffer.writerIndex(buffer.writerIndex() + count);
    +         if (buffer.writableBytes() <= 0) {
    --- End diff --
    
    shouldn't this be if (buffer.writableBytes() < count)
    
    you may get into a situation that you have space for just part of the buffer coming.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message