activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtaylor <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-488 Fix OpenWire Test (Temp...
Date Wed, 20 Apr 2016 13:48:16 GMT
Github user mtaylor commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/469#issuecomment-212432383
  
    @howardgao Just looking at this, wanted just to say it's usually good practice to keep
the commits within reasonably small scope.  This makes it easier to understand what the code
changes are trying to achieve, for review or when looking at the history.  It looks like you're
fixing about 5 issues in one huge commit here, would probably be best to have 1 commit per
issue/fix.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message