activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-488 Fix OpenWire Test (Temp...
Date Tue, 19 Apr 2016 19:34:14 GMT
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/469#issuecomment-212081809
  
    Ok, I like the SendResult idea after all. With just a few modifications to make it really
cool and a consistent API.
    
    
    - Rename SendResult as RoutingStatus (or find a better name, being part of Routing)
    - Move it under org.apache.activemq.artemis.core.postoffice
    - The enum constants should be. (No need to set any prefix on them).
    OK, NO_BINDINGS, NO_BINDINGS_DLA, DUPLICATED_ID
    - Notice that there's no need for SEND_NO_DLA API wise.. just make it NO_BINDINGS.
    
    - Also, make all the PostOffice::route operations to return RoutingStatus. to make the
API clean.
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message