activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-488 Fix OpenWire Test (Temp...
Date Tue, 19 Apr 2016 19:09:54 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/469#discussion_r60292159
  
    --- Diff: tests/activemq5-unit-tests/src/main/resources/stomp/META-INF/services/org.apache.activemq.artemis.spi.core.protocol.ProtocolManagerFactory
---
    @@ -0,0 +1 @@
    +org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManagerFactory
    --- End diff --
    
    Adding this file under testsuite would be a hack.
    
    The problem with that is if we ever make any changes, or need any fix.. nobody will figure
out what happened here.
    
    
    Please remove this file from the testsuite, and if you need stomp protocol manager just
add the proper dependency through the pom.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message