activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-488 Fix OpenWire Test (Temp...
Date Mon, 18 Apr 2016 17:11:38 GMT
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/469#issuecomment-211480175
  
    The proper change for the Temporary Queue would be to call internalSession.createQueue
instead of duplicating the createQueue control through the protocol head.
    
    So, that makes it two changes to the PR:
    
    
    i - adapt the create queue, and make sure the ServerSession close is called when things
happens (I think it is).
    ii - change the routing to add a new overloaded method to be used by OpenWire instead
of queueQuery on every message. (if that even is required... we need to check if that's really
needed... because if the temp queue was deleted.. it simply means we don't need to bother..
just relax the test).
    
    
    You may ping me before you do these changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message