activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-488 Fix OpenWire Test (Temp...
Date Mon, 18 Apr 2016 16:57:18 GMT
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/469#issuecomment-211472570
  
    Howard,
    
    You can't simply duplicate functionality that is already available on the Broker.
    
    ServerSessionImpl, which is used by OpenWireConnection already has controller for temporary
queues. Why we can't simply use the TemporaryQueues from The ServerSession? 
    
    
    I don't want to keep adding copy & paste inheritance on the openwire protocol head.
if something on the broker is not working as expected I would rather change with parameter
to adapt any semantics than copy & paste and duplicate functionality just to fix tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message