activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Date Wed, 13 Apr 2016 13:52:39 GMT
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/459#issuecomment-209450621
  
    I don't think the change is right anyways...
    
    incDelivering is called only after handled...
    
    The testcase is playing with cancellations and crashes. Perhaps there's a situation where
the decDelivering should be called (after some specific crash or something).. but that would
be a corner case.
    
    Having this fix here might fix the testcase but break other production cases. Needs an
overall thinking


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message