activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-468 Fix openwire redelivery...
Date Thu, 07 Apr 2016 15:58:45 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/440#discussion_r58897288
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
---
    @@ -303,6 +307,22 @@ public void setPrefetchSize(int prefetchSize) {
           }
        }
     
    +   @Override
    +   public void updateForCanceledRef(MessageReference ref) {
    +      long seqId = ref.getMessage().getMessageID();
    +      long lastDelSeqId = info.getLastDeliveredSequenceId();
    +      ServerMessage coreMessage = ref.getMessage();
    +      int redeliveryCounter = coreMessage.getIntProperty(OpenWireMessageConverter.AMQ_MSG_REDELIVER_COUNTER);
    +      if (openwireDestination.isTopic()) {
    +         redeliveryCounter++;
    +         coreMessage.putIntProperty(OpenWireMessageConverter.AMQ_MSG_REDELIVER_COUNTER,
redeliveryCounter);
    --- End diff --
    
    This is wrong anyways Howard, The same message could be delivered to another Queue (another
topic for instance).
    
    DeliveryCount is a property of the MessageReference, not message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message