activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-471 NPE during replication
Date Wed, 06 Apr 2016 19:01:29 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/441#discussion_r58762631
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
    @@ -464,7 +464,9 @@ private void sendJournalFile(JournalFile[] journalFiles, JournalContent
type) th
           for (JournalFile jf : journalFiles) {
              if (!started)
                 return;
    --- End diff --
    
    Replicator currentReplicator = replicator;
    if (currentReplicator != null) ...
    
    
    There's no lock in place ... you could have a case where it satisfies the if and you still
get the NPE.. I have seen it happening before in similar cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message