activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-358 topic mistakenly remove...
Date Mon, 25 Jan 2016 22:40:47 GMT
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/346

    ARTEMIS-358 topic mistakenly removed with sub

    The problem here is that the management notification listener was mistakenly
    removing the topic itself instead of just the non-durable subscription. In
    general I can't see why StompProtocolManager even needs to keep track of the
    destinations when the broker already does that. As far as I can tell it is
    redundant and it's clearly error-prone. Therefore I'm removing the destination
    tracking from StompProtocolManager altogether.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-358

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #346
    
----
commit 960e29afadcd3b5848a95406ad14d48099fb6c3c
Author: jbertram <jbertram@apache.org>
Date:   2016-01-25T22:36:02Z

    ARTEMIS-358 topic mistakenly removed with sub
    
    The problem here is that the management notification listener was mistakenly
    removing the topic itself instead of just the non-durable subscription. In
    general I can't see why StompProtocolManager even needs to keep track of the
    destinations when the broker already does that. As far as I can tell it is
    redundant and it's clearly error-prone. Therefore I'm removing the destination
    tracking from StompProtocolManager altogether.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message