activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scop <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: Disconnect on STOMP 1.2 errors
Date Mon, 25 Jan 2016 19:40:38 GMT
GitHub user scop opened a pull request:

    https://github.com/apache/activemq-artemis/pull/344

    Disconnect on STOMP 1.2 errors

    As required by the spec: https://stomp.github.io/stomp-specification-1.2.html#ERROR
    
    I'm not particularly happy with the AbstractStompClientConnection change (would be better
if it noticed disconnects and sets its state automatically), but it seems to get the job done
without breaking other tests. And the Thread.sleep()s are there so that the disconnect has
actually happened, not sure if there's a cleaner approach to that ready to be reused somewhere.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scop/activemq-artemis stomp12-disconnect-on-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #344
    
----
commit 23385f67c92d4dcb475832a6bdcddd056748a65b
Author: Ville Skyttä <ville.skytta@iki.fi>
Date:   2016-01-25T19:01:10Z

    Disconnect on STOMP 1.2 errors
    
    https://stomp.github.io/stomp-specification-1.2.html#ERROR

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message