activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request:
Date Thu, 31 Dec 2015 21:13:20 GMT
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/commit/b1b4bb8a32a9bb9c6d951f3d0fdd3626944319f9#commitcomment-15223936
  
    In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java:
    In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
on line 288:
    Why you want to avoid it... as soon as it return false, any returning false
    should be cached to be resumed later.
    
    I'm trying to understand why is that an issue.
    
    On Thu, Dec 31, 2015 at 4:11 PM, jimbogithub <notifications@github.com>
    wrote:
    
    > This will trigger the leak as it does not avoid subsequent calls after
    > callback.isWritable() first returns true.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/activemq-artemis/commit/b1b4bb8a32a9bb9c6d951f3d0fdd3626944319f9#commitcomment-15223925>
    > .
    >
    
    
    
    -- 
    Clebert Suconic



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message