activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: ARTEMIS-326 Quote logging configura...
Date Mon, 21 Dec 2015 23:24:09 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/282#discussion_r48204956
  
    --- Diff: pom.xml ---
    @@ -115,11 +115,11 @@
           -->
     
           <activemq-surefire-argline>-Djava.util.logging.manager=org.jboss.logmanager.LogManager
    -         -Dlogging.configuration=file:${activemq.basedir}/tests/config/logging.properties
    -         -Djava.library.path=${activemq.basedir}/artemis-native/bin/ -Djgroups.bind_addr=localhost
-Dorg.apache.activemq.artemis.api.core.UDPBroadcastEndpointFactory.localBindAddress=localhost
    +         -Dlogging.configuration='file:${activemq.basedir}/tests/config/logging.properties'
    +         -Djava.library.path='${activemq.basedir}/artemis-native/bin/' -Djgroups.bind_addr=localhost
-Dorg.apache.activemq.artemis.api.core.UDPBroadcastEndpointFactory.localBindAddress=localhost
              -Djava.net.preferIPv4Stack=true
           </activemq-surefire-argline>
    -      <activemq.basedir>${project.basedir}</activemq.basedir>
    +      <activemq.basedir>${basedir}</activemq.basedir>
    --- End diff --
    
    Agreed.  However, when I didn't use the consolidated variable, and instead let it recompute
each time, I had to quote on each declaration.  It wasn't pretty.  I can switch to that if
3.0 compatibility is a must.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message