Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 98EF418CB3 for ; Wed, 18 Nov 2015 20:56:51 +0000 (UTC) Received: (qmail 9890 invoked by uid 500); 18 Nov 2015 20:56:51 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 9830 invoked by uid 500); 18 Nov 2015 20:56:51 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 9819 invoked by uid 99); 18 Nov 2015 20:56:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Nov 2015 20:56:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 11892E0B4A; Wed, 18 Nov 2015 20:56:51 +0000 (UTC) From: jscheid To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c... Content-Type: text/plain Message-Id: <20151118205651.11892E0B4A@git1-us-west.apache.org> Date: Wed, 18 Nov 2015 20:56:51 +0000 (UTC) Github user jscheid commented on the pull request: https://github.com/apache/activemq-artemis/pull/208#issuecomment-157861049 We've discussed this more on IRC and it turns out this is a bad idea. According to the STOMP protocol, the client can ask for no heartbeats (and STOMP 1.0 doesn't support heartbeats at all) and so the server runs in danger of leaking connections when dealing with badly behaved clients when there is no hard upper limit on connection TTL. We've agreed the correct fix is instead to improve the documentation to point out that TTL needs to be configured correctly on the server to suit the use case, and that clients can't expect long heart beat intervals (or no heart beating at all) to work. Also, it would be good if Artemis could add a mechanism to configure per-acceptor TTL but that is a separate issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---