Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_4fbf8c5bfaf30bb58bf255a5fce60f27"
Date: Tue, 29 Sep 2015 21:44:34 +0200
From: Erik Wramner <erik@wramner.name>
To: dev@activemq.apache.org
Subject: Re: [Q] ActiveMQ coding style?
In-Reply-To: <43C630C3-70E3-41EC-B6AF-AAA7886B8A12@gmail.com>
References: <99f7adb06bd26badb58345b8de90df4d@wramner.name>
 <CACHnxzwj8=KKWrmotAjH89KgGtzLLDOv_Z4ry-T+prug+PnVRw@mail.gmail.com>
 <43C630C3-70E3-41EC-B6AF-AAA7886B8A12@gmail.com>
Message-ID: <c4245f7abc09488f7b898395a77437b3@wramner.name>
User-Agent: Roundcube Webmail/1.1.2

--=_4fbf8c5bfaf30bb58bf255a5fce60f27
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Hello again,

I have created a new Eclipse format based on Sun's (well, Oracle's now) 
template, which forms the basis for CXF. I don't use their mixed tab 
policy, but spaces only with indentation size 4. I have increased the 
maximum line length to 120 for code and comments alike.

Applying it to various source files I think it is reasonably stable. 
There are small changes (in particular for comments, we could disable 
line wrapping for them), but most of the code remains unchanged.

Please give it a try. If you like it and have commit rights, perhaps you 
could add it to git or somewhere on the site?

-Erik

On 2015-09-29 14:42, Rob Davies wrote:
> I seem to remember we used to use the CXF coding style at one point?
>> On 29 Sep 2015, at 13:16, Christopher Shannon 
>> <christopher.l.shannon@gmail.com> wrote:
>> 
>> I don't believe there is one, but if you want to put one together I 
>> would
>> also use this as a reference:
>> https://google.github.io/styleguide/javaguide.html and see how well it
>> matches up.
>> 
>> On Tue, Sep 29, 2015 at 1:17 AM, Erik Wramner <erik@wramner.name> 
>> wrote:
>> 
>>> Hello,
>>> 
>>> I wonder if there is a coding style template for ActiveMQ somewhere? 
>>> I
>>> found a discussion for ActiveMQ Artemis where one seems to have been
>>> developed, but not for core ActiveMQ. Is there one?
>>> 
>>> The code is nicely formatted as far as I'm concerned, but I have a 
>>> hard
>>> time coding without pressing Ctrl-Shift-F (auto format) in Eclipse. 
>>> It is
>>> hardwired into me by now. If we don't have a template perhaps I can 
>>> put one
>>> together based on the Artemis version and see if it matches the 
>>> existing
>>> code reasonably well?
>>> 
>>> -Erik
>>> 

--=_4fbf8c5bfaf30bb58bf255a5fce60f27
Content-Transfer-Encoding: base64
Content-Type: application/zip;
 name=ActiveMQ-Eclipse-Formatter.zip
Content-Disposition: attachment;
 filename=ActiveMQ-Eclipse-Formatter.zip;
 size=3210

UEsDBBQAAAAIALesPUcfoi607AsAAEV7AAAeAAAAQWN0aXZlTVEtRWNsaXBzZS1Gb3JtYXR0ZXIu
eG1sxV1Zj+S2EX4P4P8w6Pe0vYsgWAReHwlgwAECOEjyLLAlqps7alGmqJkd//oUqZMUxZbEouZt
t7uHpWJdXx2kvv/x6714eqGiZrz8fPpw/u70RMuUZ6y8fj7977+//PnT6amWpMxIwUv6+VTy048/
fPOn7yvBc1bQevK3H0+TL56eWZl9Pv2DZ/QXLu5ESip+a786PZXkDkv9nEr2Qv/179NsjZpKCQ/w
xGAFLq5nmhasqun5SybPKRf0nPdLnllZUyGTuiIpTUgOHyW0UL9mNaxLigYItb85fRu+dMrvd5Kw
MqFlc08y+GMiiIRHxyJW0tekYCXVNO6VfEtIWXKpaUzpIZFrebtQ+IKOzJGi4GlLkn6tBK3rKcWM
P8ETPSESJlJTHRmVbxXF5FZxRkt57ne3ViQvwORzcuEN6LZgdJSgFA3dTMKnLCnoByyaSi6mXCUV
/ONO4afB2tMzaGsR/GKkEkrEXrzlciI2zVL6TK4UiVSvJfKV0t4egB1a1oMN6r0lpURSz0tByude
RzR/7F5xIUcJfdi8ptPWCl7Dn7fcKGZeb9ozojCxpA0dbcG5TCS5BmvdKinZZn2n9wsVTusO49rr
0sAAbjwzrE/eBH+tkYj3W95+knwhLyTjadJ9HOxbMlhEP/W5Zn+MavKXHUvN3FTFa5mzrwmvKOwM
F0g74nOIyi2xMhXU3JwIlLTKEXFt8CnZKtYyxSSWSnkQAS/f7ryp0eOkYydremcpB+zXsRhKImM1
uRTK9YEHGhb7afjB33ieb14UggD8tGntemItw/ofNy9JCnYtldJouRqhZhTwd5uXncaXToHCA8w8
aNlhePuaDlW4sJKIt7mf2KkJPrO9N4VkVUETBUQLVKBtCnZwDcuA4sNfN9NwsAa7ViqtJ+UV2LoI
EBDVsHeAZ+DYs9aiBc0phM8UHw8oy3DE/11R6VWQqtdhLga1aGUH6UN6C1uflg8cRbl5SZfKdUBM
SUT7WJ0WhCqZK1BoSCRvtNaCHhMrRVRQ2Yhg922qdotvgEHS1NSNgRB0/EE2YKceYYr8TGkFfAHK
BBOVGj0oMjUQ0Q8xkMlJUW/XuDUs5YwWWaigfK4PFKNgKZOTpBFcYIEOYua4Al/zu2AE/gwfX5qR
tM09bDwUElSdWM92FkQI8qZRHwPj+wMtx/bnijnaJnoC1UDNdOXR6M0C4wJ0R3kAr4m3fhJVkgtb
W7+ySHvbx+WO4qiwx+QOS5q7FAORtqCkL6pi08IcLd8+AW9dt6glfFI095HglkgBi1WsADqV4JeC
3s8KMP6qiDEIC6NNUiHAQtet6VUYUmaDJWCX8TyJOcMIMloGQ5iuFQ0l/URyK9DsAoetQlegXtpq
1XOvUG0K+8nzFipspejS798bWnc5Z/LKiiwlIkNSZZ81D+Y0+q2IVO0aGitf+u5AJO/sd2GW09xJ
qs+JtJcoaHmV45IfPm5P7BXGVuEjzxFSK2sfpoXVLkDWI/o4ulszE4g7bcah6K4pzzQxBrudC4bt
7JKqKIWPpU2NGp4X4EiOhit761LqSMULVe0NSS2ppjyjOsQZkXpXZJ7x6QV4bVHphQhGLkVwr8oR
ijyZNnYImkGsWLZhFheacmjo9OU6M0/YX1EwgQle5Rm8lGo8weYb9VIJO3llpbYE+K7bvgvP3gaC
26OBi5VOUGvznJ1c6hIJBcuJUyIxtaCrCDvCDpb4O+ixqki6c8e8mGc5wQ+zJh+zQ/Fb15pQi99+
XrHRpK/U3lW5jNkIVecK0yCddCjbNXZtmnu4x2mSGyXZRLjhqM2Sad0AeGAlfJbDt5Hk2PnKjOYE
VAhJiA6upmkPyC/TgY8UoUw5AqmZKYbETsfiC2M5scgV5H7JiBlZQkhopU5l6+xZjqi7tmMw6w9H
JHsLxceYlGLhpqqRXf5iBOQeoIaJzfSwo4g6y/Sq9y4H64laK6oDO7fQE0eWpbaDvQf9M7QNndUR
IcmEfUGrJPbZV1pQIgy0y7r+Zp9tBaJBO9nqHYcyWu04xETrkexplTED4VCls3mDRKHz1mqGGRxu
cme1QvRIfHmFZs2T4YjNacaHdLRiTpJ0JBo3hTAZWUNBQ9pT+3dutWMYKbX/MiojypKE+vvFXsau
EDKmxW2UanUOkHJfuxnZ2Ly2U9E6lJqSOkrqNpv+DxO5i4QxE6d8HOwUb8QU1yMStfatjRUxdm5W
SpqASkR+nOjyiE5CzG7afJriPQq4kdurfYhyOCfMhoel8AW50ALYmQOJnWxoLz4dRtfd4daXhpaf
Lag6NA+GZXfXEuca5ipV7tySNZUTvWHodZIHLZ7IxwQW7CjGyRJTM6x60OCXgvKKkZhjzLhDDAXo
5EzOAdppsjWpBrncz6ft69vav30SK0xs3tC14WBX2FN0HvfaEJExUvZJqW5nodT1XWzOzGKCB3by
YUvT1Z1TdoBEx8kO7qSvo9Bnnw0dSIRU+5aKozMoHUJkFSp8VAYJ03QLY1jxZp9ye+pH/uGJHZ53
TXiJVWpcZcTmQcNNlIa6lercX2kJBJWa/bMWf3+TVH040ULVWs9WLrxRA1HHJk3l8MCO7bHrC1f7
LUhV0XbIARMlLwGnuObZz/VpCbin+5Q3wmV0FvG7zvn7zD/N1fGtTG+ClyrpQqLbe0HjwHpfBMQ6
su6coRwi8WFDlJgzHqYxD2WZxCoJ78ChCm5JclGpYvHW9vMgNCk9mJw3DBSIlSJA1qut2BsxdoQo
Y0raaAcgj0m3uz8+6vnTyhW2hdMI9ucg+xD0W+fJd1IGHWsKvSDSUe953SDevKbdS/B6ZjyCU2Rv
hIb5jFAEtejr2XiDEBYGbs0oMfDVLv+yKis6pAE0i6FT74wuoxX1+p3EnHWW6QHB7YHG8fz2/ThI
O7V0ar7LkpbUYPtZegdLEU9OOGRineja3shyFO/aShpy3e5hkXCxtrCDmMswlzoImlEV4EItxosA
l0v9e1Rilq5KSP2p/A3Cq3qeIFziwM5WVooPkx+MEu7ZonVx3HF5jqPCGUbYKgm2TUFsj/cAOxwX
/965c3eT9xGkhEMJd5RadoxhvLg01Ttbj6erdrOjHcCclMV3eWGdh02GL4bV8g1J10rnsWqQHl0+
UYZxVtlV/E6eWU6ee6xABGgLcPniyTCm2nMj7f1StgdE7TM9rB9acXQvHTOqDMNBtXbyLEfCGH6p
HXx48KAWjQNgq31Ob005ttO2Y2w3ENCQEOnB10w52PaFP/HwoGZxWDl7oZoWV3fcvg2/hOIzk/e4
gsvr09fh6wgPsPFIYrwnGLWP1DEdMvIUpbPUoMdpjSGGcF/YLa57t+rxM35I/Fp0UsfZyJKKHmCz
Hpz3ewNf5gwoxxogsMLghjQ1jGmbPDO6BqjzrG0wFpQ8H9k/tqcwIse4hSgbdbR6qHdHpHHcrcHe
wz2I1B6hhPhBcQmR4cVEqw5kNn/xba478gq+Crlw7B+swjdpnR2ze9Ue/MJMh/1Bd7xfB9Hz+g6N
enZwfyzr2WsHli6zG4yiRO/ttn0I5l68TxuR1OPyPc6swiPtPTCv9d02Nz0fscu1WSOCxvUcNZp9
WFIzKpd4Z6mdsVxEuaDVMV62CFpDumXTi6gvCydLd8n9kX4/ulV558b5tAK5oeHi0JGTh07bTjqx
EEMZmXr5Pd1X32O/zxDQ8hU6GFTsgtEj34DI4Pz2QfrgtDMq8Y5v15nhGHQ2vH4An/w8x1/RS41E
/zgLsojHx/I6XPBG2e30BP+rula+pLWcDJGGRw2zP+1O6Xby4Yiv7m5nSGx1EIkyGO6opFbWO0xw
GqkzPcsP6sk5p5QRCQ7OK+fOlyuFGc0qFt/nVV8LtQDMF6qtgkkxRg38KGD1myIiPITN/ZGzWoel
7yvbxQMSi9QrjlZGWwIej3rAiLS3HqsIE6k+kddGGU0yVuFz80BaGFuuR4h0SWNfQe6MY2AFZFan
glWGnoTsp937zCGzL4o3vYkRrhWbnLtJb2S0Yb2nm1fzavqa+13DmHG9G6d9zVxyFbypJkWrzWur
Vf8DgWfygrQd1+WvieBxQ8oiTlt+vcC33butp/+u4T//B1BLAQIUABQAAAAIALesPUcfoi607AsA
AEV7AAAeAAAAAAAAAAEAIAAAAAAAAABBY3RpdmVNUS1FY2xpcHNlLUZvcm1hdHRlci54bWxQSwUG
AAAAAAEAAQBMAAAAKAwAAAAA
--=_4fbf8c5bfaf30bb58bf255a5fce60f27--