Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: Clebert <clebert.suconic@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Subject: Re: Content length on stomp messages
Message-Id: <99C920DF-3316-4463-8D10-E1A345EDA776@gmail.com>
Date: Wed, 26 Aug 2015 21:01:51 -0400
References: 
 <CAOqetn8fPdRwSr+TBLNLJ9zntvyTK1Q2JTWV8EFGfcLvbinncQ@mail.gmail.com>
 <CAGZ-RDLa8xRw0ktE3KccdJoXJTekS_+N7ub+=P8FT318tdJRrQ@mail.gmail.com>
 <CAOqetn-utYN+NvnOSAv3UN3XWmQzK7ixDxcAMPDmwSvhDvrS2g@mail.gmail.com>
In-Reply-To: 
 <CAOqetn-utYN+NvnOSAv3UN3XWmQzK7ixDxcAMPDmwSvhDvrS2g@mail.gmail.com>
To: "dev@activemq.apache.org" <dev@activemq.apache.org>

I'm confused if there is an issue or not?

If there is can u send a fix ? :)

-- Clebert Suconic typing on the iPhone.=20

> On Aug 26, 2015, at 18:22, John D. Ament <john.d.ament@gmail.com> wrote:
>=20
> What you're saying is true, but it's also indicative of a potential
> overflow issue.
>=20
> John
>=20
> On Wed, Aug 26, 2015 at 6:16 PM Hiram Chirino <hiram@hiramchirino.com>
> wrote:
>=20
>> if content length is 1000, then the message body should be 1000 bytes.
>> If the frame has less then that it's an error on the sending side of
>> the protocol encoder
>>=20
>> On Mon, Jul 20, 2015 at 12:57 PM, John D. Ament <johndament@apache.org>
>> wrote:
>>> Hey guys!
>>>=20
>>> Following up on a conversation was having on github via stomp messages.
>>>=20
>>> I think we do have a bug with the content length, where we can try to
>> read
>>> larger than the message.
>> https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/=
artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protoc=
ol/stomp/StompDecoder.java#L230
>>>=20
>>> If I'm reading this right, if the content length is manually set to 1000=

>>> and there's only 200 bytes we might be trying to get 1000.  Not sure wha=
t
>>> will happen, does it read into the next message?
>>>=20
>>> John
>>=20
>>=20
>>=20
>> --
>> Hiram Chirino
>> Engineering | Red Hat, Inc.
>> hchirino@redhat.com | fusesource.com | redhat.com
>> skype: hiramchirino | twitter: @hiramchirino
>>=20