activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hiram Chirino <hi...@hiramchirino.com>
Subject Re: Content length on stomp messages
Date Thu, 27 Aug 2015 13:35:16 GMT
Can you explain the overflow issue?

On Wed, Aug 26, 2015 at 6:22 PM, John D. Ament <john.d.ament@gmail.com> wrote:
> What you're saying is true, but it's also indicative of a potential
> overflow issue.
>
> John
>
> On Wed, Aug 26, 2015 at 6:16 PM Hiram Chirino <hiram@hiramchirino.com>
> wrote:
>
>> if content length is 1000, then the message body should be 1000 bytes.
>> If the frame has less then that it's an error on the sending side of
>> the protocol encoder
>>
>> On Mon, Jul 20, 2015 at 12:57 PM, John D. Ament <johndament@apache.org>
>> wrote:
>> > Hey guys!
>> >
>> > Following up on a conversation was having on github via stomp messages.
>> >
>> > I think we do have a bug with the content length, where we can try to
>> read
>> > larger than the message.
>> >
>> >
>> https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompDecoder.java#L230
>> >
>> > If I'm reading this right, if the content length is manually set to 1000
>> > and there's only 200 bytes we might be trying to get 1000.  Not sure what
>> > will happen, does it read into the next message?
>> >
>> > John
>>
>>
>>
>> --
>> Hiram Chirino
>> Engineering | Red Hat, Inc.
>> hchirino@redhat.com | fusesource.com | redhat.com
>> skype: hiramchirino | twitter: @hiramchirino
>>



-- 
Hiram Chirino
Engineering | Red Hat, Inc.
hchirino@redhat.com | fusesource.com | redhat.com
skype: hiramchirino | twitter: @hiramchirino

Mime
View raw message