activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: [DISCUSS] Artemis Coding Style
Date Tue, 04 Aug 2015 15:28:42 GMT
Lazy consensus is fine.    Wait till tomorrow and if no one objects, just do it.

Dan


> On Aug 4, 2015, at 11:24 AM, Clebert Suconic <clebert.suconic@gmail.com> wrote:
> 
> Is this a just do it thing, or we need a vote?
> 
> On Tue, Aug 4, 2015 at 10:07 AM, Timothy Bish <tabish121@gmail.com> wrote:
>> On 08/04/2015 07:56 AM, Christopher Shannon wrote:
>>> So in general I'm not too picky with coding styles but I just started
>>> looking at the Artemis project a few days ago and something that stood out
>>> to me right away was the use of opening curly braces on a new line.
>>> 
>>> Virtually ever Java code base I've seen is written in the style using the
>>> opening brace on the same line. (See
>>> http://google.github.io/styleguide/javaguide.html#s4.1.2-blocks-k-r-style)
>>> I think that in general it would be a good idea to match up to a style
>>> that most Java developers are used to working with if we want to get more
>>> of the community involved.
>>> 
>>> I was wondering if anyone would have an issue with changing the style or
>>> what people's thoughts are about this potential change?
>>> 
>> +1
>> 
>> I think following the javaguide style would make the code much more
>> approachable.
>> 
>> --
>> Tim Bish
>> Sr Software Engineer | RedHat Inc.
>> tim.bish@redhat.com | www.redhat.com
>> twitter: @tabish121
>> blog: http://timbish.blogspot.com/
>> 
> 
> 
> 
> -- 
> Clebert Suconic

-- 
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com


Mime
View raw message