activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request: Pass JNDI name in XARecoveryConfig
Date Wed, 26 Aug 2015 13:47:26 GMT
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/138#issuecomment-135026215
  
    I just think the parameter name jndiName is a too generic name.. it's not clear if that
means the connectionFactory or the TM...
    
    
    I would rename it to something else with its purpose.. such as tmRegistry, recoveryRegistry,
etc...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message