Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAMgYm0wuRG0T-E_9VxsouydZBiYrVgSXpi23yTm6ndxgu70-Sg@mail.gmail.com>
References: 
 <CAMgYm0ygkK9bmaGyvb85AphPEAdi3rvk9JUGSCfEFK3Qcwci3w@mail.gmail.com>
	<1811551184.15128779.1433770531217.JavaMail.zimbra@redhat.com>
	<6DAB46EB-91E0-45AE-AA4D-DBC7D4466794@apache.org>
	<2079974312.15145151.1433771649474.JavaMail.zimbra@redhat.com>
	<BC5D7EE2-9A89-4D26-9807-8594CA55A859@apache.org>
	<5575C09E.3040000@gmail.com>
	<CAMgYm0wuRG0T-E_9VxsouydZBiYrVgSXpi23yTm6ndxgu70-Sg@mail.gmail.com>
Date: Mon, 8 Jun 2015 14:27:57 -0400
Message-ID: 
 <CAKF+bsqRxWFq20hMSrZiV1qLHyQVFQEOVtW30Tka2ymoVQTwhQ@mail.gmail.com>
Subject: Re: Git workflow for committers
From: Clebert Suconic <clebert.suconic@gmail.com>
To: "dev@activemq.apache.org" <dev@activemq.apache.org>
Content-Type: text/plain; charset=UTF-8

I was reading a glossary of terms here, and what we have differs quite
a lot from the definition of ReviewThenCommit:

http://www.apache.org/foundation/glossary.html#ReviewThenCommit

The definition here means a vote for commits. What we do at artemis is
quite fast.. it's just one other person reviewing stuff to improve
quality. not something to burden the dev process with an expensive
workflow.


We usually ask more than one person to review more substantial
changes, but it's always the dev asking for help rather than the
expensive workflow.


This could be a nice tool for people sumitting PRs even on ActiveMQ
codebase. I would not mandate this as a process on activemq5 but it's
definitely a nice tool to have for anyone developing