Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Message-ID: <5576F9F1.9070102@gmail.com>
Date: Tue, 09 Jun 2015 15:36:33 +0100
From: Andy Taylor <andy.tayls67@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: dev@activemq.apache.org
Subject: Re: Git workflow for committers
References: 
 <CAMgYm0ygkK9bmaGyvb85AphPEAdi3rvk9JUGSCfEFK3Qcwci3w@mail.gmail.com>
	<1811551184.15128779.1433770531217.JavaMail.zimbra@redhat.com>
	<6DAB46EB-91E0-45AE-AA4D-DBC7D4466794@apache.org>
	<2079974312.15145151.1433771649474.JavaMail.zimbra@redhat.com>
	<BC5D7EE2-9A89-4D26-9807-8594CA55A859@apache.org>
	<5575C09E.3040000@gmail.com>
	<CAMgYm0wuRG0T-E_9VxsouydZBiYrVgSXpi23yTm6ndxgu70-Sg@mail.gmail.com>
	<506E747B-88D3-4E65-97BB-DD05D9D8B62D@apache.org>
	<CAKF+bso=4uQgwKeLEE=485yqEJRZhNvFoMjHrAD_6xvr-XR0=g@mail.gmail.com>
	<83FD022B-E8AC-47CC-83E4-25516EC24E02@apache.org>
	<CAKF+bsoTm3y+QRPO5LJH0tJ5ygKiJ9gY8HKBRGnqZdt-eKMVtw@mail.gmail.com>
 <CAKF+bsoGoc6b9B4we7b2_gFyFgS-xurJ1EAMMSq8obHq7JQwQQ@mail.gmail.com>
In-Reply-To: 
 <CAKF+bsoGoc6b9B4we7b2_gFyFgS-xurJ1EAMMSq8obHq7JQwQQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

If anyone doesnt want to use Github then they can simply use git to 
create a patch and send it to the dev list. Another committer can then 
review it, raise a PR, wait for the CI build to test it and then it can 
be merged in the usual way. This way we keep all the info we need and a 
consistent graph.
On 09/06/15 15:32, Clebert Suconic wrote:
>> It turns out we didn’t have a build setup for that.   We do now.
>
> The build I sent you before was a PR build from my own PR. Unless you
> set it up somewhere. Did you set up a new build for that?
>
> On Tue, Jun 9, 2015 at 10:29 AM, Clebert Suconic
> <clebert.suconic@gmail.com> wrote:
>>> Well,  I fixed that situation this morning.   I *THOUGHT* we had a CI build that was running on master on all commits.   That was the expectation and if something broke I would have gotten a “this is broken” email within 15 minutes or so.   It turns out we didn’t have a build setup for that.   We do now.
>>>
>>
>> I was not being specific about the situation itself.. just finding it
>> as an example on where the CI build would been useful.
>>
>> We have a CI build that run on every Pull Request, not on every commit.
>>
>> We have a daily build but they are not as fast on catching issues.
>>
>>
>>>> I'm asking if you could at least send a PR and wait for the build to finish.
>>>
>>> How do I do a pull request that doesn’t involve github?   I’m not using github for development.
>>>
>>
>> You really need github for that. You would need a github account
>> associated with your apache email and send send the PR.
>>
>> You don't want to use github at all? If you don't want to use github,
>> then you certainly won't be able to use these tools.
>>
>> Do you have any issues on using github?
>
>
>