Return-Path: 
 <dev-return-51505-apmail-activemq-dev-archive=activemq.apache.org@activemq.apache.org>
X-Original-To: apmail-activemq-dev-archive@www.apache.org
Delivered-To: apmail-activemq-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 385EF17E74
	for <apmail-activemq-dev-archive@www.apache.org>;
 Wed, 10 Jun 2015 16:30:53 +0000 (UTC)
Received: (qmail 37268 invoked by uid 500); 10 Jun 2015 16:30:53 -0000
Delivered-To: apmail-activemq-dev-archive@activemq.apache.org
Received: (qmail 37207 invoked by uid 500); 10 Jun 2015 16:30:53 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 37193 invoked by uid 99); 10 Jun 2015 16:30:52 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jun 2015 16:30:52 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 99F7DE04B0; Wed, 10 Jun 2015 16:30:52 +0000 (UTC)
From: thiagokronig <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-8-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-8-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq
 unit te...
Content-Type: text/plain
Message-Id: <20150610163052.99F7DE04B0@git1-us-west.apache.org>
Date: Wed, 10 Jun 2015 16:30:52 +0000 (UTC)

Github user thiagokronig commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/8#issuecomment-110823751
  
    @clebertsuconic we are skipping checkstyle, may we skip Error Prone also,
    just to maintain certain compatibility with the ActiveMQ codebase?
    
    On Wed, Jun 10, 2015 at 1:09 PM Thiago Kronig <thiagokronig@gmail.com>
    wrote:
    
    > @clebertsuconic, here:
    >
    > tests/activemq5-unit-tests/pom.xml:23:
    >  <version>1.0.0-SNAPSHOT</version>
    >
    > Changing to 1.0.1-SNAPHOT breaks the build because of ErrorProne.
    > I'm fixing those errors at this moment. Should submit a PR in the
    > following hours.
    >
    >
    > On Tue, Jun 9, 2015 at 11:07 PM clebertsuconic <notifications@github.com>
    > wrote:
    >
    >> @thiagokronig <https://github.com/thiagokronig> where you are saying
    >> that?
    >> and how to enforce that kind of rule. I'm not sure where it's missing a
    >> parent as snapshot
    >>
    >> —
    >> Reply to this email directly or view it on GitHub
    >> <https://github.com/apache/activemq-artemis/pull/8#issuecomment-110558166>
    >> .
    >>
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---