Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-15-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-15-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request: Connection Factory updates
Content-Type: text/plain
Message-Id: <20150604033506.1C8B4DFF7B@git1-us-west.apache.org>
Date: Thu,  4 Jun 2015 03:35:06 +0000 (UTC)

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/15#discussion_r31691246
  
    --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/ConnectionTest.java ---
    @@ -65,6 +67,33 @@ public void testManyConnections() throws Exception
        //
     
        @Test
    +   public void testThroughNewConnectionFactory() throws Exception
    +   {
    +      testThroughNewConnectionFactory(new ActiveMQConnectionFactory());
    +      testThroughNewConnectionFactory(new ActiveMQConnectionFactory("tcp://localhost:61616"));
    +      testThroughNewConnectionFactory(new ActiveMQConnectionFactory("tcp://localhost:61616", "guest", "guest"));
    +   }
    +
    +   private void testThroughNewConnectionFactory(ActiveMQConnectionFactory factory) throws Exception
    +   {
    +      Connection conn = factory.createConnection();
    +      conn.close();
    +
    +      try (JMSContext ctx = factory.createContext())
    +      {
    +         ctx.createProducer().send(ctx.createQueue("queue"),"Test");
    +      }
    +
    +      try (JMSContext ctx = factory.createContext())
    +      {
    +         Assert.assertNotNull(ctx.createConsumer(ctx.createQueue("queue")).receiveNoWait());
    +         Assert.assertNull(ctx.createConsumer(ctx.createQueue("queue")).receiveNoWait());
    +      }
    +
    +      factory.close();
    --- End diff --
    
    good idea!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---