Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7D91118BF4 for ; Mon, 1 Jun 2015 02:55:09 +0000 (UTC) Received: (qmail 48019 invoked by uid 500); 1 Jun 2015 02:55:09 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 47943 invoked by uid 500); 1 Jun 2015 02:55:09 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 47932 invoked by uid 99); 1 Jun 2015 02:55:08 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jun 2015 02:55:08 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BD9A3DFDB1; Mon, 1 Jun 2015 02:55:08 +0000 (UTC) From: clebertsuconic To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te... Content-Type: text/plain Message-Id: <20150601025508.BD9A3DFDB1@git1-us-west.apache.org> Date: Mon, 1 Jun 2015 02:55:08 +0000 (UTC) Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107289228 Just commit the code you need. a patch is not a good solution on moving forward. It's impossible to maintain it. If you don't need the patch, then we need to refactor the tests properly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---