activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clebert Suconic <clebert.suco...@gmail.com>
Subject Re: Git workflow for committers
Date Tue, 09 Jun 2015 14:39:15 GMT
I believe there is a way to send pull requests without using github:

type this on git:

git help request-pull



But I have no idea how to use it.

On Tue, Jun 9, 2015 at 10:36 AM, Andy Taylor <andy.tayls67@gmail.com> wrote:
> If anyone doesnt want to use Github then they can simply use git to create a
> patch and send it to the dev list. Another committer can then review it,
> raise a PR, wait for the CI build to test it and then it can be merged in
> the usual way. This way we keep all the info we need and a consistent graph.
>
> On 09/06/15 15:32, Clebert Suconic wrote:
>>>
>>> It turns out we didn’t have a build setup for that.   We do now.
>>
>>
>> The build I sent you before was a PR build from my own PR. Unless you
>> set it up somewhere. Did you set up a new build for that?
>>
>> On Tue, Jun 9, 2015 at 10:29 AM, Clebert Suconic
>> <clebert.suconic@gmail.com> wrote:
>>>>
>>>> Well,  I fixed that situation this morning.   I *THOUGHT* we had a CI
>>>> build that was running on master on all commits.   That was the expectation
>>>> and if something broke I would have gotten a “this is broken” email within
>>>> 15 minutes or so.   It turns out we didn’t have a build setup for that.
  We
>>>> do now.
>>>>
>>>
>>> I was not being specific about the situation itself.. just finding it
>>> as an example on where the CI build would been useful.
>>>
>>> We have a CI build that run on every Pull Request, not on every commit.
>>>
>>> We have a daily build but they are not as fast on catching issues.
>>>
>>>
>>>>> I'm asking if you could at least send a PR and wait for the build to
>>>>> finish.
>>>>
>>>>
>>>> How do I do a pull request that doesn’t involve github?   I’m not using
>>>> github for development.
>>>>
>>>
>>> You really need github for that. You would need a github account
>>> associated with your apache email and send send the PR.
>>>
>>> You don't want to use github at all? If you don't want to use github,
>>> then you certainly won't be able to use these tools.
>>>
>>> Do you have any issues on using github?
>>
>>
>>
>>
>



-- 
Clebert Suconic
http://community.jboss.org/people/clebert.suconic@jboss.com
http://clebertsuconic.blogspot.com

Mime
View raw message