activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Gomes <jgo...@apache.org>
Subject Re: Git workflow for committers
Date Tue, 09 Jun 2015 23:50:05 GMT
+1 to stay with the existing CTR practice that is well established in the
ActiveMQ community. That's why committership is granted. It's a level of
trust and confidence that you don't make low hanging fruit errors.

On Tue, Jun 9, 2015, 8:03 AM Daniel Kulp <dkulp@apache.org> wrote:

>
> > On Jun 9, 2015, at 10:47 AM, Andy Taylor <andy.tayls67@gmail.com> wrote:
> >
> > Dan,
> >
> > are you implying you are going to bypass the workflow that everyone else
> is using and commit directly? shouldnt we be consistent?
>
> That IS being consistent with the workflow that the *ACTIVEMQ* community
> has been using for the last 10+ years and has been using with the git repo
> for the last 2 years.    So yes, I will be using the workflow that the
> community has agreed on and been using.   Thanks for asking.
>
> Dan
>
>
> >
> > On 09/06/15 15:45, Daniel Kulp wrote:
> >>
> >>> On Jun 9, 2015, at 10:32 AM, Clebert Suconic <
> clebert.suconic@gmail.com> wrote:
> >>>
> >>>> It turns out we didn’t have a build setup for that.   We do now.
> >>>
> >>> The build I sent you before was a PR build from my own PR. Unless you
> >>> set it up somewhere. Did you set up a new build for that?
> >>
> >> Yes:
> >>
> >>
> https://builds.apache.org/view/A-D/view/ActiveMQ/job/ActiveMQ-Artemis-Master/
> >>
> >> It builds on each commit to the canonical repository.
> >>
> >>
> >> Dan
> >>
> >>
> >>
> >>>
> >>> On Tue, Jun 9, 2015 at 10:29 AM, Clebert Suconic
> >>> <clebert.suconic@gmail.com> wrote:
> >>>>> Well,  I fixed that situation this morning.   I *THOUGHT* we had
a
> CI build that was running on master on all commits.   That was the
> expectation and if something broke I would have gotten a “this is broken”
> email within 15 minutes or so.   It turns out we didn’t have a build setup
> for that.   We do now.
> >>>>>
> >>>>
> >>>> I was not being specific about the situation itself.. just finding it
> >>>> as an example on where the CI build would been useful.
> >>>>
> >>>> We have a CI build that run on every Pull Request, not on every
> commit.
> >>>>
> >>>> We have a daily build but they are not as fast on catching issues.
> >>>>
> >>>>
> >>>>>> I'm asking if you could at least send a PR and wait for the
build
> to finish.
> >>>>>
> >>>>> How do I do a pull request that doesn’t involve github?   I’m
not
> using github for development.
> >>>>>
> >>>>
> >>>> You really need github for that. You would need a github account
> >>>> associated with your apache email and send send the PR.
> >>>>
> >>>> You don't want to use github at all? If you don't want to use github,
> >>>> then you certainly won't be able to use these tools.
> >>>>
> >>>> Do you have any issues on using github?
> >>>
> >>>
> >>>
> >>> --
> >>> Clebert Suconic
> >>> http://community.jboss.org/people/clebert.suconic@jboss.com
> >>> http://clebertsuconic.blogspot.com
> >>
> >
>
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message