activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <>
Subject [GitHub] activemq-artemis pull request: Hacking guide
Date Tue, 19 May 2015 21:58:55 GMT
GitHub user jbertram opened a pull request:

    Hacking guide


You can merge this pull request into a Git repository by running:

    $ git pull hacking_guide

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #271
commit 70258865a5e595c194dee178d23759133b9aae7b
Author: jbertram <>
Date:   2015-05-13T17:49:42Z

    Initial commit of the hacking guide

commit 99147d0713bd1688e4c79b6d2e551bff9203ea4a
Author: jbertram <>
Date:   2015-05-18T16:07:28Z

    Refactor base test classes
    This has bothered me for awhile, but writing the hacking guide has
    given me an opportunity to refactor some of our test-suite to be
    simpler, more consistent, and easier to understand. This is
    important if we want users to provide well-written tests. Our
    test-suite is an important part of the code-base and it should be
    easy to write good tests.
    Basically I just consolidated CoreUnitTestCase, UnitTestCase, and
    ServiceTestBase into a single class named ServiceTestBase. I also
    simplified some of the configuration creation methods to reduce
    duplicated code.

commit 4b833cf5e79324453b7fa51a4158e890b23048b5
Author: jbertram <>
Date:   2015-05-19T21:16:51Z

    ACTIVEMQ6-111 journal dir created even if persistence disabled

commit a9f475ee47b3611fc466c2a80ae9323b22540750
Author: jbertram <>
Date:   2015-05-19T21:19:03Z

    Fix test config
    This configuration should not have a "data" folder hence should not
    have persistence enabled.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message