activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thiago Kronig <thiagokro...@gmail.com>
Subject Re: [DISCUSSION] Error prone plugin on codebase
Date Fri, 29 May 2015 05:47:03 GMT
It can be very helpful*

On Fri, May 29, 2015, 02:46 Thiago Kronig <thiagokronig@gmail.com> wrote:

> Just explaining a bit: Error Prone differs on Pmd and FindBugs as it works
> at compile time, leveraging the AST to do the work. Or can be very helpful
> as it emits compile warnings and errors.
>
> We could, of course, just limit to a specific profile, as it is plugged as
> a build maven plugin.
>
> On Thu, May 28, 2015, 23:34 Clebert Suconic <clebert.suconic@gmail.com>
> wrote:
>
>> Thiago Kronig has recently added error prone to the Artemis codebase,
>> so any mistakes would be noticed at compilation time.
>>
>> I actually liked it quite a lot... Liking even more now as I realize
>> what is doing :)
>>
>>
>>
>> I'm now cleaning up all the warnings we had on the codebase based on
>> the plugin and I'm pushing the parameters a step further:
>>
>> These following mistakes will now be reported as compilation errors:
>>
>> <arg>-Xep:NonAtomicVolatileUpdate:ERROR</arg>
>> <arg>-Xep:SynchronizeOnNonFinalField:ERROR</arg>
>> <arg>-Xep:StaticAccessedFromInstance:ERROR</arg>
>> <arg>-Xep:WaitNotInLoop:ERROR</arg>
>>
>>
>> For more information on their meaning:
>>
>> http://errorprone.info/bugpattern/NonAtomicVolatileUpdate
>> http://errorprone.info/bugpattern/SynchronizeOnNonFinalField
>> http://errorprone.info/bugpattern/StaticAccessedFromInstance
>> http://errorprone.info/bugpattern/WaitNotInLoop
>>
>>
>> Any objections?
>> https://github.com/apache/activemq-artemis/pull/7
>>
>>
>> Clebert
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message