activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lazar Bankovic <lazar.banko...@gmail.com>
Subject Re: [DISCUSSION] Error prone plugin on codebase
Date Fri, 29 May 2015 11:43:26 GMT
unsubscribe

2015-05-29 4:33 GMT+02:00 Clebert Suconic <clebert.suconic@gmail.com>:

> Thiago Kronig has recently added error prone to the Artemis codebase,
> so any mistakes would be noticed at compilation time.
>
> I actually liked it quite a lot... Liking even more now as I realize
> what is doing :)
>
>
>
> I'm now cleaning up all the warnings we had on the codebase based on
> the plugin and I'm pushing the parameters a step further:
>
> These following mistakes will now be reported as compilation errors:
>
> <arg>-Xep:NonAtomicVolatileUpdate:ERROR</arg>
> <arg>-Xep:SynchronizeOnNonFinalField:ERROR</arg>
> <arg>-Xep:StaticAccessedFromInstance:ERROR</arg>
> <arg>-Xep:WaitNotInLoop:ERROR</arg>
>
>
> For more information on their meaning:
>
> http://errorprone.info/bugpattern/NonAtomicVolatileUpdate
> http://errorprone.info/bugpattern/SynchronizeOnNonFinalField
> http://errorprone.info/bugpattern/StaticAccessedFromInstance
> http://errorprone.info/bugpattern/WaitNotInLoop
>
>
> Any objections?
> https://github.com/apache/activemq-artemis/pull/7
>
>
> Clebert
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message