activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-5719) Add clientId and subscriptionName to all durable-related exceptions and log messages within TopicRegion
Date Mon, 13 Apr 2015 20:23:12 GMT

    [ https://issues.apache.org/jira/browse/AMQ-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493007#comment-14493007
] 

ASF GitHub Bot commented on AMQ-5719:
-------------------------------------

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq/pull/86

    Updated durable related error messages in TopicRegion

    Updated durable related error messages in TopicRegion to include both subscriptionName
and clientId.
    
        This resolves https://issues.apache.org/jira/browse/AMQ-5719

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq AMQ-5719

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #86
    
----
commit 72837960cffc58b559ced6c243a459c62cb153cf
Author: Christopher L. Shannon (cshannon) <christopher.l.shannon@gmail.com>
Date:   2015-04-13T20:17:01Z

    Updated durable related error messages in TopicRegion to include both subscriptionName
and clientId.
    
    This resolves https://issues.apache.org/jira/browse/AMQ-5719

----


> Add clientId and subscriptionName to all durable-related exceptions and log messages
within TopicRegion
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-5719
>                 URL: https://issues.apache.org/jira/browse/AMQ-5719
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.11.1
>            Reporter: Christopher L. Shannon
>            Priority: Minor
>              Labels: easyfix
>
> In order to make it easier to debug durable related issues it would be useful if the
error messages included the {{clientId}} and {{subscriptionName}}.  
> The specific use case for this was that a client tried to remove their durable subscription
using the wrong {{clientId}} and received an error message which did not include the {{clientId}}
so it was difficult to debug.  
> The error received just said: {{javax.jms.InvalidDestinationException: No durable subscription
exists for: <subscriptionName>}}
> It would be more useful if the error was: {{javax.jms.InvalidDestinationException: No
durable subscription exists for clientId: <clientId> and subscriptionName: <subscriptionName>}}
> I will be attaching a pull request to this ticket with the 2 specific exception messages
I would like to see changed in {{TopicRegion}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message