Return-Path: 
 <dev-return-49760-apmail-activemq-dev-archive=activemq.apache.org@activemq.apache.org>
X-Original-To: apmail-activemq-dev-archive@www.apache.org
Delivered-To: apmail-activemq-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C918817B50
	for <apmail-activemq-dev-archive@www.apache.org>;
 Tue, 24 Mar 2015 19:47:53 +0000 (UTC)
Received: (qmail 77402 invoked by uid 500); 24 Mar 2015 19:47:53 -0000
Delivered-To: apmail-activemq-dev-archive@activemq.apache.org
Received: (qmail 77346 invoked by uid 500); 24 Mar 2015 19:47:53 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 77330 invoked by uid 99); 24 Mar 2015 19:47:53 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2015 19:47:53 +0000
Date: Tue, 24 Mar 2015 19:47:53 +0000 (UTC)
From: "Christopher L. Shannon (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Message-ID: <JIRA.12785280.1427226436000.13108.1427226473455@Atlassian.JIRA>
In-Reply-To: <JIRA.12785280.1427226436000@Atlassian.JIRA>
References: <JIRA.12785280.1427226436000@Atlassian.JIRA>
 <JIRA.12785280.1427226436586@arcas>
Subject: [jira] [Created] (AMQ-5686) ProxyMessageStore doesn't properly
 delegate
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Christopher L. Shannon created AMQ-5686:
-------------------------------------------

             Summary: ProxyMessageStore doesn't properly delegate
                 Key: AMQ-5686
                 URL: https://issues.apache.org/jira/browse/AMQ-5686
             Project: ActiveMQ
          Issue Type: Bug
          Components: Broker
    Affects Versions: 5.11.1
            Reporter: Christopher L. Shannon


In ProxyMessageStore the method {{asyncAddTopicMessage}} does not call the delegate method as it should.  This causes a {{StackOverflowError}} if the method is called as it will just recursively keep calling the same method over and over again.

The problem is here on line 141 of {{ProxyMessageStore.java}}:

{code}
@Override
public ListenableFuture<Object> asyncAddTopicMessage(ConnectionContext context, Message message, boolean canOptimizeHint) throws IOException {
  return asyncAddtopicMessage(context,message,canOptimizeHint);
}
{code}

This simply should be changed to:

{code}
@Override
public ListenableFuture<Object> asyncAddTopicMessage(ConnectionContext context, Message message, boolean canOptimizeHint) throws IOException {
  return delegate.asyncAddtopicMessage(context,message,canOptimizeHint);
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)