activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher L. Shannon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-5686) ProxyMessageStore doesn't properly delegate
Date Wed, 25 Mar 2015 14:28:52 GMT

    [ https://issues.apache.org/jira/browse/AMQ-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379922#comment-14379922
] 

Christopher L. Shannon commented on AMQ-5686:
---------------------------------------------

Thanks for taking care of that so fast.

> ProxyMessageStore doesn't properly delegate
> -------------------------------------------
>
>                 Key: AMQ-5686
>                 URL: https://issues.apache.org/jira/browse/AMQ-5686
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.11.1
>            Reporter: Christopher L. Shannon
>            Assignee: Timothy Bish
>              Labels: easyfix
>             Fix For: 5.12.0
>
>
> In ProxyMessageStore the method {{asyncAddTopicMessage}} does not call the delegate method
as it should.  This causes a {{StackOverflowError}} if the method is called as it will just
recursively keep calling the same method over and over again.
> The problem is here on line 141 of {{ProxyMessageStore.java}}:
> {code}
> @Override
> public ListenableFuture<Object> asyncAddTopicMessage(ConnectionContext context,
Message message, boolean canOptimizeHint) throws IOException {
>   return asyncAddTopicMessage(context,message,canOptimizeHint);
> }
> {code}
> This simply should be changed to:
> {code}
> @Override
> public ListenableFuture<Object> asyncAddTopicMessage(ConnectionContext context,
Message message, boolean canOptimizeHint) throws IOException {
>   return delegate.asyncAddTopicMessage(context,message,canOptimizeHint);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message