activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hadrian Zbarcea <hzbar...@gmail.com>
Subject Re: activemq git commit: Add MERIT.txt and give thanks to Mark Frazier for his contribution.
Date Mon, 09 Mar 2015 18:09:25 GMT
Unnecessary bureaucracy.

We should do things right and give credit during commits, not come up 
with workarounds for process in code. There are other solutions. Ok, one 
for Mark was missed. Hopefully he'll contribute more and it won't matter 
in the great scheme of things.

In other words: how many additions to you expect to the MERIT.txt file 
in the next, say, 6 months? Did you see something similar in other 
projects? Is that something we want to pioneer?

To be clear, I agree with the (small) problem. I just think there are 
better solutions.

Hadrian



On 03/09/2015 02:02 PM, Arthur Naseef wrote:
> This file is intended to catch missed commit credit.  Reverting and
> re-applying commits to correct commit messages could get very messy, so
> this seems like a good compromise - a place to edit and create another
> commit and refer back to the original.
>
> Why it is important not to have MERIT.txt in the source code?
>
> Art
>
>
> On Mon, Mar 9, 2015 at 10:59 AM, Hadrian Zbarcea <hzbarcea@gmail.com
> <mailto:hzbarcea@gmail.com>> wrote:
>
>     -1. Please remove. Does not belong in the code repository.
>     I agree that credit should be given, but imo this is not the way.
>
>     Hadrian
>
>
>
>     On 03/09/2015 01:52 PM, artnaseef@apache.org
>     <mailto:artnaseef@apache.org> wrote:
>
>         Repository: activemq
>         Updated Branches:
>             refs/heads/master e25a6aa8a -> b9b566918
>
>
>         Add MERIT.txt and give thanks to Mark Frazier for his contribution.
>
>
>         Project: http://git-wip-us.apache.org/__repos/asf/activemq/repo
>         <http://git-wip-us.apache.org/repos/asf/activemq/repo>
>         Commit:
>         http://git-wip-us.apache.org/__repos/asf/activemq/commit/__b9b56691
>         <http://git-wip-us.apache.org/repos/asf/activemq/commit/b9b56691>
>         Tree:
>         http://git-wip-us.apache.org/__repos/asf/activemq/tree/__b9b56691 <http://git-wip-us.apache.org/repos/asf/activemq/tree/b9b56691>
>         Diff:
>         http://git-wip-us.apache.org/__repos/asf/activemq/diff/__b9b56691 <http://git-wip-us.apache.org/repos/asf/activemq/diff/b9b56691>
>
>         Branch: refs/heads/master
>         Commit: b9b566918e4e0ce0c33e0a4f73aff7__551b7d6c66
>         Parents: e25a6aa
>         Author: artnaseef <artnaseef@apache.org
>         <mailto:artnaseef@apache.org>>
>         Authored: Mon Mar 9 10:50:59 2015 -0700
>         Committer: artnaseef <artnaseef@apache.org
>         <mailto:artnaseef@apache.org>>
>         Committed: Mon Mar 9 10:51:51 2015 -0700
>
>         ------------------------------__------------------------------__----------
>            MERIT.txt | 15 +++++++++++++++
>            1 file changed, 15 insertions(+)
>         ------------------------------__------------------------------__----------
>
>
>         http://git-wip-us.apache.org/__repos/asf/activemq/blob/__b9b56691/MERIT.txt
>         <http://git-wip-us.apache.org/repos/asf/activemq/blob/b9b56691/MERIT.txt>
>         ------------------------------__------------------------------__----------
>         diff --git a/MERIT.txt b/MERIT.txt
>         new file mode 100644
>         index 0000000..1cec26b
>         --- /dev/null
>         +++ b/MERIT.txt
>         @@ -0,0 +1,15 @@
>         +OVERVIEW
>         +========
>         +
>         +This file contains thanks to contributors.  Not all
>         contributions are here, but
>         +this file acts as a place to give thanks to those whose
>         contributions are not
>         +otherwise reflected in source code commits.
>         +
>         +
>         +MERIT
>         +=====
>         +
>         +Commit: 3ef8f492a7cb9c056ac1883ccb069e__9559fc6b22
>         +       Author: Mark Frazier
>         +       Message: Thank you for the patch provided here:
>         + https://issues.apache.org/__jira/browse/AMQ-5563
>         <https://issues.apache.org/jira/browse/AMQ-5563>
>
>

Mime
View raw message