Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EFE3117DA9 for ; Tue, 24 Feb 2015 18:44:05 +0000 (UTC) Received: (qmail 34661 invoked by uid 500); 24 Feb 2015 18:44:05 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 34591 invoked by uid 500); 24 Feb 2015 18:44:05 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 34579 invoked by uid 99); 24 Feb 2015 18:44:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2015 18:44:05 +0000 Date: Tue, 24 Feb 2015 18:44:05 +0000 (UTC) From: "Robbie Gemmell (JIRA)" To: dev@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMQ-5597) AMQP: clean up durable subscription unsubscribe handling to simplify and resolve issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated AMQ-5597: -------------------------------- Attachment: AMQ-5597_v2.patch Updated patch with a small tweak to set a 'not found' error condition on the detach when the 'null source lookup' attach used during unsubscribe fails to find a matching subscription. This also prevents the NPE seen in the old client, without the client change mentioned above. > AMQP: clean up durable subscription unsubscribe handling to simplify and resolve issues > --------------------------------------------------------------------------------------- > > Key: AMQ-5597 > URL: https://issues.apache.org/jira/browse/AMQ-5597 > Project: ActiveMQ > Issue Type: Sub-task > Components: AMQP > Affects Versions: 5.11.0, 5.11.1 > Reporter: Robbie Gemmell > Fix For: 5.12.0 > > Attachments: AMQ-5597.patch, AMQ-5597_v2.patch > > > The current unsubscribe processing is identifying a 'null-source lookup' attach as indication to immediately unsubscribe a durable subscription, performing some trickery with capabilities. There are actually many other reasons reasons a client might do this type of attach, which might lead to prematurely ending a subscription. Fully closing (rather than a non-closing detach) the durable subscription link is to be the signal ending the subscription. The related code should be fixed to resolve this, and generally cleaned up to simplify things. -- This message was sent by Atlassian JIRA (v6.3.4#6332)