activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AMQ-5604) AMQP: Clean up unit test start / stop code, excessive thread creation casuse slowdowns.
Date Fri, 20 Feb 2015 16:40:12 GMT
Timothy Bish created AMQ-5604:
---------------------------------

             Summary: AMQP: Clean up unit test start / stop code, excessive thread creation
casuse slowdowns.
                 Key: AMQ-5604
                 URL: https://issues.apache.org/jira/browse/AMQ-5604
             Project: ActiveMQ
          Issue Type: Sub-task
          Components: AMQP
    Affects Versions: 5.11.0, 5.11.1
            Reporter: Timothy Bish
            Assignee: Timothy Bish
            Priority: Minor
             Fix For: 5.12.0


The current test support code uses single thread executor instances as defense against hangs
on test tearDown but is a bit aggressive with it as it also does Broker start / stop in an
executor and never reuses them so every test run requires three to four threads just to start
stop.  There's also some thread interruption bits that blindly interrupt anything that is
not the main thread which could lead to problems with the JUnit threads etc.  We can reduce
this all down to one executor to close the legacy QPid JMS client connection which does sometimes
hang on close. 

This shaves off anywhere from 1.5 to 2 minutes from the test run. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message