activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gaohoward <...@git.apache.org>
Subject [GitHub] activemq-6 pull request: ACTIVEMQ6-61 SelectorParser package confl...
Date Wed, 17 Dec 2014 02:10:37 GMT
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-6/pull/47

    ACTIVEMQ6-61 SelectorParser package conflict with openwire tests

    The SelectorParser class in amq6 source code conflicts
    with the same class in activemq 5 client jar. The activemq 5
    client jar is needed to run openwire tests where the activemq5
    client interacts with amq6 broker. In tests they are usually
    in the same VM, so depending on the classpath order, whichever
    class is loaded it will be used by both client and broker.
    Unfortunately the method parse() in the class has different
    return types in the client jar and broker side jar.
    That will cause NoSuchMethod exception.
    
    The fix moves the broker side class into a different package, i.e.
    from
    org.apache.activemq.selector.SelectorParser
    to
    org.apache.activemq.selector.impl.SelectorParser

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-6 master_selector

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-6/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit 7ffa23799be0c0e43cc2db5423bac3ffbb06a7a8
Author: Howard Gao <hgao@redhat.com>
Date:   2014-12-17T01:56:11Z

    ACTIVEMQ6-61 SelectorParser package conflict with openwire tests
    
    The SelectorParser class in amq6 source code conflicts
    with the same class in activemq 5 client jar. The activemq 5
    client jar is needed to run openwire tests where the activemq5
    client interacts with amq6 broker. In tests they are usually
    in the same VM, so depending on the classpath order, whichever
    class is loaded it will be used by both client and broker.
    Unfortunately the method parse() in the class has different
    return types in the client jar and broker side jar.
    That will cause NoSuchMethod exception.
    
    The fix moves the broker side class into a different package, i.e.
    from
    org.apache.activemq.selector.SelectorParser
    to
    org.apache.activemq.selector.impl.SelectorParser

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message