activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "can_do (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AMQ-5462) dead code in method createSession of class ActiveMQConnection
Date Fri, 28 Nov 2014 06:24:13 GMT

     [ https://issues.apache.org/jira/browse/AMQ-5462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

can_do updated AMQ-5462:
------------------------
    Description: 
org.apache.activemq.ActiveMQConnection ==>
in method "public Session createSession(boolean transacted, int acknowledgeMode)  throws JMSException"

 in statement [return new EMQSession ... ]
code [acknowledgeMode == Session.SESSION_TRANSACTED] is dead.
because this condition has been decided in method entrance.
Futhermore when using tranaction,the acknowledge mode must be 0.
This is right or not?

  was:
org.apache.activemq.ActiveMQConnection ==>
in method public Session createSession(boolean transacted, int acknowledgeMode)
    throws JMSException

 in statement [return new EMQSession ... ]
code [acknowledgeMode == Session.SESSION_TRANSACTED] is dead.
becuase this condition has been decided in method entrance.


> dead code in method createSession of class ActiveMQConnection 
> --------------------------------------------------------------
>
>                 Key: AMQ-5462
>                 URL: https://issues.apache.org/jira/browse/AMQ-5462
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>    Affects Versions: 5.8.0, 5.9.0, 5.9.1, 5.10.0
>         Environment: 64bit win7+64bit jdk1.7.0_72
>            Reporter: can_do
>            Priority: Minor
>             Fix For: NEEDS_REVIEW
>
>
> org.apache.activemq.ActiveMQConnection ==>
> in method "public Session createSession(boolean transacted, int acknowledgeMode)  throws
JMSException"
>  in statement [return new EMQSession ... ]
> code [acknowledgeMode == Session.SESSION_TRANSACTED] is dead.
> because this condition has been decided in method entrance.
> Futhermore when using tranaction,the acknowledge mode must be 0.
> This is right or not?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message