Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Fri, 26 Sep 2014 20:24:33 +0000 (UTC)
From: "Tim Bain (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Message-ID: <JIRA.12741849.1410885748000.134557.1411763073620@Atlassian.JIRA>
In-Reply-To: <JIRA.12741849.1410885748000@Atlassian.JIRA>
References: <JIRA.12741849.1410885748000@Atlassian.JIRA>
 <JIRA.12741849.1410885748088@arcas>
Subject: [jira] [Updated] (AMQ-5361) Allow multiple slow consumer strategies
 to be used together
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/AMQ-5361?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Bain updated AMQ-5361:
--------------------------
    Summary: Allow multiple slow consumer strategies to be used together  (=
was: Allow for multiple slow consumer strategies to be used together)

> Allow multiple slow consumer strategies to be used together
> -----------------------------------------------------------
>
>                 Key: AMQ-5361
>                 URL: https://issues.apache.org/jira/browse/AMQ-5361
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.9.0
>            Reporter: Tim Bain
>
> AMQ-378 allowed a pluggable policy for aborting consumers that were slow,=
 where a consumer was slow if the broker was holding a number of messages f=
or it equal to the consumer's prefetch buffer size, in addition to the same=
 number of messages already in the consumer's prefetch buffer.  AMQ-4621 ad=
ded the ability to use a different slow consumer strategy and provided one =
other strategy, to consider a consumer slow if it hasn't acked a message in=
 a certain amount of time.
> These strategies each has certain things it protects well against while n=
ot protecting against others, but I want the ability to be protected from a=
ll of them, by being able to select multiple SlowConsumerStrategy implement=
ations for my needs.  This would also allow us to use future SlowConsumerSt=
rategy implementations (e.g. AMQ-5361) alongside the two that exist today.
> This should be done by extracting from the SlowConsumerStrategy interface=
 a SlowConsumerIdentificationStrategy interface that would determine which =
consumers were considered slow according to that strategy.  We'd end up wit=
h two classers implementing SlowConsumerIdentificationStrategy (e.g. Pendin=
gMessagesSlowConsumerIdentificationStrategy and AckDelaySlowConsumerIdentif=
icationStrategy), extracted from AbortSlowConsumerStrategy and AbortSlowAck=
ConsumerStrategy, respectively.  AbortSlowAckConsumerStrategy should go awa=
y (anything in it that doesn't belong in AckDelaySlowConsumerIdentification=
Strategy belongs in AbortSlowConsumerStrategy or is already there e.g. the =
run() method), and AbortSlowConsumerStrategy should get a Set<SlowConsumerI=
dentificationStrategy> to allow multiple different SlowConsumerIdentificati=
onStrategies to be used together.  The union of the results of calling each=
 SlowConsumerIdentificationStrategy's identifySlowConsumers() method should=
 then be passed to abortSubscription().


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)