activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (AMQ-5326) SslTransport doesn't support soWriteTimeout
Date Thu, 21 Aug 2014 20:57:13 GMT

    [ https://issues.apache.org/jira/browse/AMQ-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105011#comment-14105011
] 

Timothy Bish edited comment on AMQ-5326 at 8/21/14 8:56 PM:
------------------------------------------------------------

Fixed.
{noformat}

--- a/src/main/java/org/apache/activemq/transport/tcp/TcpTransportFactory.java
+++ b/src/main/java/org/apache/activemq/transport/tcp/TcpTransportFactory.java
@@ -111,6 +111,10 @@ public class TcpTransportFactory extends TransportFactory {
         return super.compositeConfigure(transport, format, options);
     }
 
+    protected Transport swtCompositeConfigure(Transport transport, WireFormat format, Map
options) {
+        return super.compositeConfigure(transport, format, options);
+    }
+
     /**
      * Returns true if the inactivity monitor should be used on the transport
      */
~

--- a/src/main/java/org/apache/activemq/transport/tcp/SslTransportFactory.java
+++ b/src/main/java/org/apache/activemq/transport/tcp/SslTransportFactory.java
@@ -114,8 +114,8 @@ public class SslTransportFactory extends TcpTransportFactory {
         if (format instanceof OpenWireFormat) {
             transport = new WireFormatNegotiator(transport, (OpenWireFormat)format, sslTransport.getMinmumWireFormatVersion());
         }
-
-        return transport;
+        
+        return super.swtCompositeConfigure(transport, format, options);
     }
 
     /**

{noformat}


was (Author: lei huang):
Fixed.

--- a/src/main/java/org/apache/activemq/transport/tcp/TcpTransportFactory.java
+++ b/src/main/java/org/apache/activemq/transport/tcp/TcpTransportFactory.java
@@ -111,6 +111,10 @@ public class TcpTransportFactory extends TransportFactory {
         return super.compositeConfigure(transport, format, options);
     }
 
+    protected Transport swtCompositeConfigure(Transport transport, WireFormat format, Map
options) {
+        return super.compositeConfigure(transport, format, options);
+    }
+
     /**
      * Returns true if the inactivity monitor should be used on the transport
      */
~

--- a/src/main/java/org/apache/activemq/transport/tcp/SslTransportFactory.java
+++ b/src/main/java/org/apache/activemq/transport/tcp/SslTransportFactory.java
@@ -114,8 +114,8 @@ public class SslTransportFactory extends TcpTransportFactory {
         if (format instanceof OpenWireFormat) {
             transport = new WireFormatNegotiator(transport, (OpenWireFormat)format, sslTransport.getMinmumWireFormatVersion());
         }
-
-        return transport;
+        
+        return super.swtCompositeConfigure(transport, format, options);
     }
 
     /**

> SslTransport doesn't support soWriteTimeout
> -------------------------------------------
>
>                 Key: AMQ-5326
>                 URL: https://issues.apache.org/jira/browse/AMQ-5326
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.5.1
>         Environment: Linux
>            Reporter: Lei Huang
>
> ActimveMQ 5.5.1 doesn't support soWriteTimeout for SslTransport. 
> ssl://0.0.0.0:61616?transport.soWriteTimeout=2000
> will throw IllegalArgumentException.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message