Return-Path: X-Original-To: apmail-activemq-dev-archive@www.apache.org Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0FCE10A6D for ; Fri, 6 Jun 2014 04:27:01 +0000 (UTC) Received: (qmail 33319 invoked by uid 500); 6 Jun 2014 04:27:01 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 33258 invoked by uid 500); 6 Jun 2014 04:27:01 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 33248 invoked by uid 99); 6 Jun 2014 04:27:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jun 2014 04:27:01 +0000 Date: Fri, 6 Jun 2014 04:27:01 +0000 (UTC) From: "Ben O'Day (JIRA)" To: dev@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMQ-5211) ActiveMQDestination.createDestination() should prevent empty destination name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben O'Day updated AMQ-5211: --------------------------- Attachment: AMQ-5211.patch patch to add validation with simple unit tests for empty queue/topic names... > ActiveMQDestination.createDestination() should prevent empty destination name > ----------------------------------------------------------------------------- > > Key: AMQ-5211 > URL: https://issues.apache.org/jira/browse/AMQ-5211 > Project: ActiveMQ > Issue Type: Bug > Affects Versions: 5.9.0 > Reporter: Ben O'Day > Priority: Minor > Attachments: AMQ-5211.patch > > > currently you can call ActiveMQDestination createDestination("",ActiveMQDestination.QUEUE_TYPE) to create a queue with no name. > while this doesn't seem to be an issue at first...if you are using mKahadb, ActiveMQ will fail to restart after this queue/store directory are created. > see this post: http://activemq.2283324.n4.nabble.com/mkahadb-Failed-to-start-per-destination-persistence-adapter-for-destination-td4678754.html#a4679848 > the web console already prevents this, we should prevent this from other entry points to this API (QueueView.moveMessagesTo() from JMX in my case)... -- This message was sent by Atlassian JIRA (v6.2#6252)