activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AMQ-5138) Useless code in VMTransport class
Date Mon, 07 Apr 2014 15:00:29 GMT

     [ https://issues.apache.org/jira/browse/AMQ-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Timothy Bish resolved AMQ-5138.
-------------------------------

    Resolution: Fixed

> Useless code in VMTransport class
> ---------------------------------
>
>                 Key: AMQ-5138
>                 URL: https://issues.apache.org/jira/browse/AMQ-5138
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.9.0
>            Reporter: Yuriy Sidelnikov
>            Priority: Minor
>
> In VMTransport class taskRunner is set to null two times needlessly on the next line
and couple of lines below:    
>        {color:red}taskRunner = null;{color}
>             messageQueue = null;
>             if (mq != null) {
>                 mq.clear();
>             }
>             // Allow pending deliveries to finish up, but don't wait
>             // forever in case of an stalled onCommand.
>             if (tr != null) {
>                 try {
>                     tr.shutdown(TimeUnit.SECONDS.toMillis(1));
>                 } catch(Exception e) {
>                 }
>                 {color:red}taskRunner = null;{color}
>             }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message