activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Frazier (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-4963) Typo in journal-data.proto
Date Thu, 16 Jan 2014 00:08:21 GMT

    [ https://issues.apache.org/jira/browse/AMQ-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872855#comment-13872855
] 

Mark Frazier commented on AMQ-4963:
-----------------------------------

disregard second file, Safari looked like it had hung.

> Typo in journal-data.proto
> --------------------------
>
>                 Key: AMQ-4963
>                 URL: https://issues.apache.org/jira/browse/AMQ-4963
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Lionel Cons
>         Attachments: AMQ-4963.patch, AMQ-4963.patch
>
>
> There seems to be a typo in activemq-kahadb-store/src/main/proto/journal-data.proto.
This file contains:
> {code}
> message KahaLocalTransactionId {
>   required string connection_id=1;
>   required int64 transaction_id=1;
> }
> {code}
> The second field should be 2.
> I wonder why the protobuf compiler does not complain about this. Maybe it should be fixed
to detect and complain about duplicate fields?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message