Return-Path: 
 <dev-return-40186-apmail-activemq-dev-archive=activemq.apache.org@activemq.apache.org>
X-Original-To: apmail-activemq-dev-archive@www.apache.org
Delivered-To: apmail-activemq-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 156CDF9DA
	for <apmail-activemq-dev-archive@www.apache.org>;
 Mon,  2 Sep 2013 08:47:59 +0000 (UTC)
Received: (qmail 56805 invoked by uid 500); 2 Sep 2013 08:47:56 -0000
Delivered-To: apmail-activemq-dev-archive@activemq.apache.org
Received: (qmail 56724 invoked by uid 500); 2 Sep 2013 08:47:54 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 56662 invoked by uid 99); 2 Sep 2013 08:47:51 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2013 08:47:51 +0000
Date: Mon, 2 Sep 2013 08:47:51 +0000 (UTC)
From: "Kevin Earls (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Message-ID: <JIRA.12654475.1372074436333.67490.1378111671814@arcas>
In-Reply-To: <JIRA.12654475.1372074436333@arcas>
References: <JIRA.12654475.1372074436333@arcas>
Subject: [jira] [Updated] (AMQ-4596) AMQP: JMSSecurityExceptions are not
 propagated back to QPID client on authentication failures
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/AMQ-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Earls updated AMQ-4596:
-----------------------------

    Attachment: AMQ-4596_final.patch

Tim, this patch should work correctly.  Please note a couple of things:

1. This includes the code change for AMQ4696, so you should probably apply that first, or ask me for another update.
2. Besides the changes for this bug (which occurs at line 405) there are several other changes for things that were either deprecated in or removed from proton-jms 0.5

                
> AMQP: JMSSecurityExceptions are not propagated back to QPID client on authentication failures
> ---------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4596
>                 URL: https://issues.apache.org/jira/browse/AMQ-4596
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>            Reporter: Kevin Earls
>            Assignee: Timothy Bish
>             Fix For: 5.9.0
>
>         Attachments: AMQ-4596_final.patch, AMQ-4596-partial.patch, AMQ-4596.patch, AMQ-4596_updated.patch
>
>
> I created a broker using a config file that contained:
> <simpleAuthenticationPlugin>
>     <users>
>         <authenticationUser username="system" password="systemPassword" groups="users,admins"/>
>        <authenticationUser username="user" password="userPassword" groups="users"/>
>        <authenticationUser username="guest" password="guestPassword" groups="guests"/>
>     </users>
> </simpleAuthenticationPlugin>
> With a normal client, the following code will throw a JMSSecurityException on the connection.start(), or connection.createProducer(), or I assume on anything you do with connection.  The same is true if I call createConnection with an unknown user, or a known user and invalid password
>     ActiveMQConnectionFactory factory = new ActiveMQConnectionFactory("vm://localhost");
>     Connection connection = factory.createConnection();
>     connection.start();
> When I use the QPID client though, I don't get the JMSSecurityException.  In the logs I can see the exception being thrown by the broker, but it doesn't get propagated back to the client, even if I add an exception listener.  The code below will continue along until it hangs on the session.CreateProducer() call.
>     ConnectionFactoryImpl factory = new ConnectionFactoryImpl("localhost", port, "admin", "password");
>      Connection connection = factory.createConnection();
>      connection.setExceptionListener(new ExceptionListener() {
>          @Override
>          public void onException(JMSException exception) {
>              exception.printStackTrace();
>          }
>      });
>      Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
>      QueueImpl queue = new QueueImpl("queue://txqueue");
>      MessageProducer p = session.createProducer(queue);
> I will attach a unit test that reproduces this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira