Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Received-SPF: pass (nike.apache.org: domain of paul.n.gale@gmail.com
 designates 209.85.219.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <JIRA.12666575.1378124517244.100990.1378736031594@arcas>
References: <JIRA.12666575.1378124517244@arcas>
 <JIRA.12666575.1378124517244.100990.1378736031594@arcas>
From: Paul Gale <paul.n.gale@gmail.com>
Date: Mon, 9 Sep 2013 10:16:43 -0400
Message-ID: 
 <CAJ5znhu27yqLH3R8LGfMYa15x2ivBp9B_0w6WYjLXNCLSLa37Q@mail.gmail.com>
Subject: Re: [jira] [Issue Comment Deleted] (AMQ-4710) The first heart-beat
 after a connection becomes idle isn't sent as quickly as it should be
To: dev <dev@activemq.apache.org>
Content-Type: multipart/alternative; boundary=e89a8fb1ef6a6a7c0304e5f40bf2

--e89a8fb1ef6a6a7c0304e5f40bf2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

If any of the ActiveMQ committers could take a look at my patch for this
Jira issue I would really appreciate the feedback as I'd like to
incorporate it into 5.8.0.

Thanks,
Paul


On Mon, Sep 9, 2013 at 10:13 AM, Paul Gale (JIRA) <jira@apache.org> wrote:

>
>      [
> https://issues.apache.org/jira/browse/AMQ-4710?page=3Dcom.atlassian.jira.=
plugin.system.issuetabpanels:all-tabpanel]
>
> Paul Gale updated AMQ-4710:
> ---------------------------
>
>     Comment: was deleted
>
> (was: Updated patch containing fix for Jira AMQ-4710. Improved the
> checking for when to recreate the write checker timer task. Previous patc=
h
> attachment has been deleted.)
>
> > The first heart-beat after a connection becomes idle isn't sent as
> quickly as it should be
> >
> -------------------------------------------------------------------------=
-----------------
> >
> >                 Key: AMQ-4710
> >                 URL: https://issues.apache.org/jira/browse/AMQ-4710
> >             Project: ActiveMQ
> >          Issue Type: Bug
> >          Components: stomp
> >    Affects Versions: 5.8.0
> >            Reporter: Andy Wilkinson
> >         Attachments: amq-4710.diff
> >
> >
> > After ActiveMQ sends a stomp frame, it may not send a heart-beat for up
> to almost 2x the negotiated interval.
> > The following test should illustrate the problem:
> > {code}
> > import org.junit.Test;
> > import static org.junit.Assert.*;
> > public class ActiveMqHeartbeatTests {
> >       @Test
> >       public void heartbeats() throws Exception {
> >               BrokerService broker =3D createAndStartBroker();
> >               Socket socket =3D null;
> >               try {
> >                       socket =3D new Socket("localhost", 61613);
> >                       byte[] connectFrame =3D
> "CONNECT\nheart-beat:0,10000\naccept-version:1.2\n\n\0".getBytes();
> >                       socket.getOutputStream().write(connectFrame);
> >                       byte[] buffer =3D new byte[4096];
> >                       long lastReadTime =3D System.currentTimeMillis();
> >                       while (true) {
> >                               int read =3D
> socket.getInputStream().read(buffer);
> >                               byte[] frame =3D Arrays.copyOf(buffer, re=
ad);
> >                               long now =3D System.currentTimeMillis();
> >                               long timeSinceLastRead =3D now -
> lastReadTime;
> >                               lastReadTime =3D now;
> >                               System.out.println(new String(frame));
> >                               System.out.println("Time since last read:
> " + timeSinceLastRead + "ms");
> >                               if (timeSinceLastRead > 15000) {
> >                                       fail("Data not received for " +
> timeSinceLastRead + "ms");
> >                               }
> >                       }
> >               } finally {
> >                       if (socket !=3D null) {
> >                               socket.close();
> >                       }
> >                       broker.stop();
> >               }
> >       }
> >       private BrokerService createAndStartBroker() throws Exception {
> >               BrokerService broker =3D new BrokerService();
> >               broker.addConnector("stomp://localhost:61613");
> >               broker.setStartAsync(false);
> >               broker.setDeleteAllMessagesOnStartup(true);
> >               broker.start();
> >               return broker;
> >       }
> > }
> > {code}
> > For the initial read of the CONNECTED frame I see:
> > {noformat}
> > Time since last read: 49ms
> > {noformat}
> > However, it's then almost 20 seconds before a heart-beat's sent:
> > {noformat}
> > Time since last read: 19994ms
> > {noformat}
> > If I comment out the fail(=E2=80=A6) line in the test, after the first =
heartbeat
> taking almost 20000ms to be sent, things settle down and a heartbeat's
> received every 10000ms.
> > It looks like the write checker wakes up every 10000ms. The first time
> it wakes up, it notices that the CONNECTED frame was sent and does nothin=
g.
> It then sleeps for a further 10000ms before checking again. As the
> CONNECTED frame was sent very early in the first 10000ms window, this lea=
ds
> to it taking almost 20000ms for the first heart-beat to be sent. From thi=
s
> point, as no further data frames are sent, the write checker wakes up and
> sends a heart-beat every 10000ms.
> > In short, I don't think ActiveMQ is adhering to the requirement that
> "the sender MUST send new data over the network connection at least every
> <n> milliseconds".
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

--e89a8fb1ef6a6a7c0304e5f40bf2--